Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API rate limit leading to Netlify build fail #7

Open
ravicodelabs opened this issue Mar 27, 2023 · 6 comments
Open

API rate limit leading to Netlify build fail #7

ravicodelabs opened this issue Mar 27, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@ravicodelabs
Copy link

ravicodelabs commented Mar 27, 2023

Describe the bug

I am getting the following error intermittently (sometimes with a different IP address) when trying to deploy from Netlify using netlify-plugin-quarto:

2:50:09 PM:   Error message
2:50:09 PM:   HttpError: Error message
2:50:09 PM:   API rate limit exceeded for 3.14.219.42. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)

The full deploy log is here and the website source code being deployed is here. More examples of failed deploy previews can be seen here.

It looks to me like at any given time, some subset of Netlify's build/deploy servers are rate limited from GitHub API requests (e.g. via github.js), leading to a build failure and the above error.

Any thoughts on the above or what's happening here? Any ideas for setting things up to avoid this rate limit issue?

Steps to reproduce

  1. Start with a simple Quarto website in a repo.
  2. Add netlify.toml and package.json as we have done here to the repo.
  3. Set up a Netlify site with Netlify's GitHub integration and try to deploy without providing a valid GITHUB_TOKEN. (If it succeeds, you may have to try a few more times.)
@ravicodelabs
Copy link
Author

ravicodelabs commented Mar 29, 2023

I have updated our deploy method to not use netlify-plugin-quarto for the time being to avoid the Netlify deploy failures we were getting. Just adding this note here in case anyone checks out the repo link in my last post.

@sagikazarmark
Copy link

#6 likely solves this problem.

Can it be released? @jjallaire maybe (as last committer in the repo)

@jjallaire
Copy link
Contributor

I'm not sure how to release the plugin -- @cscheid ?

@cscheid
Copy link
Collaborator

cscheid commented May 10, 2023

@jjallaire it should be just a matter of updating versions and npm publish, but I can do that.

@ravicodelabs
Copy link
Author

Thanks all! Just to clarify, will generating my own token and adding that as a Netlify env var GITHUB_TOKEN be sufficient here, e.g. so that I don't need a token with special permissions for the quarto-cli repo?

@sagikazarmark
Copy link

@ravicube No. The reason why you need a token is to increase the API request rate limit which is quite low for unauthenticated requests. But you don't need access to the quarto-cli repo.

I'd recommend however limiting the scopes of the token to a minumum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants