Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book 404 page does not include book navbar preventing navigation #10014

Open
cderv opened this issue Jun 14, 2024 Discussed in #9988 · 1 comment · May be fixed by #9966
Open

Book 404 page does not include book navbar preventing navigation #10014

cderv opened this issue Jun 14, 2024 Discussed in #9988 · 1 comment · May be fixed by #9966
Assignees
Labels
books bug Something isn't working
Milestone

Comments

@cderv
Copy link
Collaborator

cderv commented Jun 14, 2024

Discussed in #9988

Originally posted by meierluk June 13, 2024

Description

It would be nice if a custom 404.qmd would automatically inherit all the properties of the corresponding book project, i.e., render with the navbar etc. (as seems to have been the case with bookdown).


From #9988 (comment)

If I use the (only-slightly edited) book template, I get this 404.html, compare with the standard book layout.

The source is available on github.com/meierluk/quarto-test/.

@cderv cderv added bug Something isn't working books labels Jun 14, 2024
@cderv cderv added this to the Future milestone Jun 14, 2024
@cderv cderv self-assigned this Jun 14, 2024
@cderv
Copy link
Collaborator Author

cderv commented Jun 14, 2024

I can confirm that this is same issue as others we have. The commit which breaks this is ff820aa with the change regarding sidebar

Same cause than

which were supposed to be solved by

But it was not a good fix as it broke complex website

So still ongoing work at

Our global sidebar logic seems to be broken, and only pages identified in sidebars gets one.

@cderv cderv linked a pull request Jun 14, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
books bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant