Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.2 version broken with new Butchercraft release #25

Open
brisingraerowing opened this issue Mar 19, 2024 · 3 comments
Open

1.19.2 version broken with new Butchercraft release #25

brisingraerowing opened this issue Mar 19, 2024 · 3 comments

Comments

@brisingraerowing
Copy link

This line is the culprit

Crash Log

It seems that Butchercraft sets the spawn type to null, which seems to be valid based on the @Nullable annotations in the code.

@Lightman314
Copy link

This is 100% Butchercraft's issue, as the MobSpawnType input of the EntityType#spawn function is not flagged as nullable.

See my research here for the details.

@quat1024
Copy link
Owner

quat1024 commented Mar 22, 2024

@Nullable annotations are all stripped from Mojang's code, so in practice they're all decompiler guesswork.

This is strictly speaking not my problem - spawntype should never be null for the same reason ItemStacks shouldn't be null. There are general-use SpawnTypes for custom spawning scenarios. Regardless, Apathy could handle this more gracefully.

I haven't worked on this mod in a bit because the six dozen ForgeGradle instances take an hour+ to set up from a cold cache on my pc and it's just depressing tbh 😔

@brisingraerowing
Copy link
Author

I did a local change to work around the issue (though I later removed ButcherCraft as it has other issues currently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants