Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using grpc handler middleware/interceptors for necessary endpoints #92

Open
0xluk opened this issue Jan 8, 2025 · 1 comment · May be fixed by #99
Open

using grpc handler middleware/interceptors for necessary endpoints #92

0xluk opened this issue Jan 8, 2025 · 1 comment · May be fixed by #99
Assignees

Comments

@0xluk
Copy link
Contributor

0xluk commented Jan 8, 2025

What? Why? Who?

Currently, for archiver endpoints that requires a tick number in the request we are checking if the requested tick number is higher than last processed tick; if that's the case, we return an error saying that requested tick is in the future.

This added a lot of duplication in the handlers logic and we need change to use a middleware approach;

In gRPC the middlewares are implemented by using interceptors;

@0xluk 0xluk moved this to Backlog in integration Jan 8, 2025
@0xluk 0xluk added this to integration Jan 8, 2025
@0xluk 0xluk moved this from Backlog to Ready in integration Jan 8, 2025
@LINCKODE LINCKODE moved this from Ready to In progress in integration Jan 23, 2025
@LINCKODE LINCKODE self-assigned this Jan 27, 2025
@0xluk 0xluk moved this from In progress to Backlog in integration Jan 27, 2025
@0xluk 0xluk moved this from Backlog to Ready in integration Jan 27, 2025
@LINCKODE LINCKODE moved this from Ready to In progress in integration Jan 27, 2025
@LINCKODE
Copy link
Member

@LINCKODE LINCKODE moved this from In progress to In review in integration Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging a pull request may close this issue.

2 participants