From 7018e0c4d8d56d79b362a85e88ad4912a3f38a97 Mon Sep 17 00:00:00 2001
From: moonlitgrace <moonlitgrace.gaia@gmail.com>
Date: Sat, 21 Dec 2024 20:24:14 +0530
Subject: [PATCH] fix: dont run parallel load functions when layout data fails

---
 backend/apps/quiblet/api/v1/viewsets.py            | 2 +-
 frontend/src/routes/(app)/q/+error.svelte          | 6 +++++-
 frontend/src/routes/(app)/q/[name]/+page.server.ts | 4 +++-
 3 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/backend/apps/quiblet/api/v1/viewsets.py b/backend/apps/quiblet/api/v1/viewsets.py
index 5c5aa40d..073918c3 100644
--- a/backend/apps/quiblet/api/v1/viewsets.py
+++ b/backend/apps/quiblet/api/v1/viewsets.py
@@ -42,7 +42,7 @@ def get_object(self) -> Quiblet:  # pyright: ignore
 
         if not obj:
             raise exceptions.NotFound(
-                f'Quiblet with name {self.kwargs[self.lookup_field]} not found.'
+                f'Quiblet with name <b>{self.kwargs[self.lookup_field]}</b> not found.'
             )
         return obj
 
diff --git a/frontend/src/routes/(app)/q/+error.svelte b/frontend/src/routes/(app)/q/+error.svelte
index 33565471..ad4cad6c 100644
--- a/frontend/src/routes/(app)/q/+error.svelte
+++ b/frontend/src/routes/(app)/q/+error.svelte
@@ -3,11 +3,15 @@
   import { page } from '$app/stores';
 </script>
 
+<svelte:head>
+  <title>Quiblet not found</title>
+</svelte:head>
+
 <div class="mt-5 flex flex-1 items-end justify-center gap-5">
   <img src={Quibble404} class="w-28" alt="" />
   <div class="flex flex-col">
     <h4 class="text-xl font-bold text-error">oh noh!!</h4>
-    <h5 class="text-error">{$page.error?.message}</h5>
+    <h5>{@html $page.error?.message}</h5>
     <a href="/" aria-label="home" class="btn btn-primary btn-sm mt-4 w-max">
       <coreicons-shape-home class="size-4"></coreicons-shape-home>
       Back to home
diff --git a/frontend/src/routes/(app)/q/[name]/+page.server.ts b/frontend/src/routes/(app)/q/[name]/+page.server.ts
index 240a19a0..6ebf71ce 100644
--- a/frontend/src/routes/(app)/q/[name]/+page.server.ts
+++ b/frontend/src/routes/(app)/q/[name]/+page.server.ts
@@ -1,7 +1,9 @@
 import client from '$lib/clients/client';
 import type { PageServerLoad } from './$types';
 
-export const load: PageServerLoad = async ({ params }) => {
+export const load: PageServerLoad = async ({ params, parent }) => {
+  await parent();
+
   const [quibs, highlighted_quibs] = await Promise.all([
     client.GET('/api/v1/quiblets/{name}/quibs/', {
       params: {