Fix naming conflict on MSVC Debug mode #919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there no otehr way? I'd rather not change how users invoke the executable. |
Or renaming lib target as qjs_lib？ |
|
Maybe. The question is: why doesn't the CI fail? |
|
How about naming the library libqjs.dll on Windows targets? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is naming conflict between qjs exe and lib. When building on MSVC Debug mode, qjs.exe will link qjs.lib and generate qjs.pdb, which is conflict with qjs lib pdb file and Error like:
D:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.42.34433\bin\HostX64\x64\link.exe /ERRORREPORT:Q UEUE /OUT:"E:\codes\SCGF\build\external\quickjs\Debug\qjs.exe" /INCREMENTAL /ILK:"qjs_exe.dir\Debug\qjs.ilk" /NOLOGO Debu g\qjs.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi3 2.lib /MANIFEST /MANIFESTUAC:"level='asInvoker' uiAccess='false'" /manifest:embed /DEBUG /SUBSYSTEM:CONSOLE /TLBID:1 /DYN AMICBASE /NXCOMPAT /IMPLIB:"E:/codes/SCGF/build/external/quickjs/Debug/qjs.lib" /MACHINE:X64 /machine:x64 qjs_exe.dir\De bug\repl.obj qjs_exe.dir\Debug\standalone.obj qjs_exe.dir\Debug\qjs.obj "qjs_exe.dir\Debug\quickjs-libc.obj" 8>LINK : fatal error LNK1201: error writing to program database 'E:\codes\SCGF\build\external\quickjs\Debug\qjs.pdb'; check f or insufficient disk space, invalid path, or insufficient privilege [E:\codes\SCGF\build\external\quickjs\qjs_exe.vcxproj]