Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rest labels for v0.7 #62

Closed
tuziben opened this issue Jan 8, 2024 · 6 comments
Closed

add rest labels for v0.7 #62

tuziben opened this issue Jan 8, 2024 · 6 comments
Assignees

Comments

@tuziben
Copy link
Collaborator

tuziben commented Jan 8, 2024

should add rest labels here https://github.com/quickwit-oss/helm-charts/blob/main/charts/quickwit/templates/configmap.yaml#L13

    {{- with .Values.config.rest }}
    rest:
      {{- toYaml . | nindent 6 }}
    {{- end }}
@idrissneumann
Copy link
Collaborator

Hi.

Thanks for the issue.

I think by "rest labels" you're referring to this configuration's section? https://quickwit.io/docs/configuration/node-config#rest-configuration ?

I have opened a pull request here: #89

Tests in progress :)

@idrissneumann
Copy link
Collaborator

Tests ok, pr's ready

Screenshot 2024-06-18 at 17 30 07

@idrissneumann
Copy link
Collaborator

I think we can close this issue @rdettai @fmassot it has been handled in the #85 which just get merged :)

@guilload
Copy link
Member

You have free rein to open/close issues on this project as you see fit @idrissneumann.

@idrissneumann
Copy link
Collaborator

@guilload It doesn't seems to be the case, I can only comment ^^

Screenshot 2024-06-26 at 13 54 34

@guilload
Copy link
Member

Arf, let me fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants