Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Quickwit 4XX response body in the grafana UI #28

Closed
fmassot opened this issue Nov 23, 2023 · 2 comments
Closed

Display Quickwit 4XX response body in the grafana UI #28

fmassot opened this issue Nov 23, 2023 · 2 comments
Assignees
@idrissneumann

Comments

@fmassot
Copy link
Contributor

fmassot commented Nov 23, 2023

Currently, if Quickwit returns a 4XX, the plugin backend does not handle properly the response and the user has no feedback on the error.
We should display the error in the Grafana UI.
@idrissneumann idrissneumann mentioned this issue Nov 24, 2023
Closed
idrissneumann added a commit that referenced this issue Nov 24, 2023
@idrissneumann
Issue #28: throw the errors coming from quickwit
3af16ad
idrissneumann added a commit that referenced this issue Nov 24, 2023
@idrissneumann
Issue #28: throw the errors coming from quickwit
86bb72a
@idrissneumann
Copy link
Collaborator

Work in progress in this PR: #31

@idrissneumann idrissneumann moved this from Todo to In Progress in Quickwit grafana datasource 0.4.0 Nov 24, 2023
idrissneumann added a commit that referenced this issue Nov 24, 2023
@idrissneumann
Issue #28: move throw error in order to quit fast
4607b7d
idrissneumann added a commit that referenced this issue Nov 25, 2023
@idrissneumann
Issue #28: move throw error in order to quit fast
90be034
idrissneumann added a commit that referenced this issue Nov 25, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
cd49e72
idrissneumann added a commit that referenced this issue Nov 25, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
65a0d33
idrissneumann added a commit that referenced this issue Nov 25, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
b6bc737
idrissneumann added a commit that referenced this issue Nov 25, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
3b56a94
idrissneumann added a commit that referenced this issue Nov 27, 2023
@idrissneumann
Issue #28: try to add the experimental features for error handling
9ee64fe
idrissneumann added a commit that referenced this issue Nov 27, 2023
@idrissneumann
Revert "Issue #28: try to add the experimental features for error han…
ece1f34 
…dling"

This reverts commit 9ee64fe.
idrissneumann added a commit that referenced this issue Nov 27, 2023
@idrissneumann
Issue #28: use the right key
5939acd
idrissneumann added a commit that referenced this issue Nov 27, 2023
@idrissneumann
Issue #28: improve asserts in unit tests
402ccd8
@idrissneumann idrissneumann moved this from In Progress to To review in Quickwit grafana datasource 0.4.0 Nov 27, 2023
fmassot added a commit that referenced this issue Dec 8, 2023
@fmassot
Merge pull request #31 from quickwit-oss/feat_display_qw_errors
28ebe43 
Issue #28: throw the errors coming from quickwit
@fmassot
Copy link
Contributor Author

fmassot commented Dec 8, 2023

Closed by #31

@fmassot fmassot closed this as completed Dec 8, 2023
idrissneumann added a commit that referenced this issue Dec 9, 2023
@idrissneumann
Issue #28: throw the errors coming from quickwit
67c8095
idrissneumann added a commit that referenced this issue Dec 9, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
3b8df87
idrissneumann added a commit that referenced this issue Dec 9, 2023
@idrissneumann
Issue #28: try to add the experimental features for error handling
d6dc9ee
idrissneumann added a commit that referenced this issue Dec 9, 2023
@idrissneumann
Revert "Issue #28: try to add the experimental features for error han…
1368136 
…dling"

This reverts commit 9ee64fe.
idrissneumann added a commit that referenced this issue Dec 9, 2023
@idrissneumann
Issue #28: use the right key
aeac91c
idrissneumann added a commit that referenced this issue Dec 9, 2023
@idrissneumann
Issue #28: improve asserts in unit tests
6ef8e3f
idrissneumann added a commit that referenced this issue Dec 11, 2023
@idrissneumann
Issue #28: throw the errors coming from quickwit
15dafed
idrissneumann added a commit that referenced this issue Dec 11, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
a665b6a
idrissneumann added a commit that referenced this issue Dec 11, 2023
@idrissneumann
Issue #28: try to add the experimental features for error handling
6dd092c
idrissneumann added a commit that referenced this issue Dec 11, 2023
@idrissneumann
Revert "Issue #28: try to add the experimental features for error han…
c107b28 
…dling"

This reverts commit 9ee64fe.
idrissneumann added a commit that referenced this issue Dec 11, 2023
@idrissneumann
Issue #28: use the right key
81ad8c9
idrissneumann added a commit that referenced this issue Dec 11, 2023
@idrissneumann
Issue #28: improve asserts in unit tests
c037165
idrissneumann added a commit that referenced this issue Dec 14, 2023
@idrissneumann
Issue #28: throw the errors coming from quickwit
06d6916
idrissneumann added a commit that referenced this issue Dec 14, 2023
@idrissneumann
Issue #28: handle errors coming from quickwit
4d3e848
idrissneumann added a commit that referenced this issue Dec 14, 2023
@idrissneumann
Issue #28: try to add the experimental features for error handling
252dd8c
idrissneumann added a commit that referenced this issue Dec 14, 2023
@idrissneumann
Revert "Issue #28: try to add the experimental features for error han…
1f35ec7 
…dling"

This reverts commit 9ee64fe.
idrissneumann added a commit that referenced this issue Dec 14, 2023
@idrissneumann
Issue #28: use the right key
bce7a7a
idrissneumann added a commit that referenced this issue Dec 14, 2023
@idrissneumann
Issue #28: improve asserts in unit tests
dd30b40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idrissneumann idrissneumann

Labels
None yet
Projects
Quickwit grafana datasource 0.4.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fmassot @idrissneumann