Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the janitor does not spam the metastore too much #5353

Closed
fulmicoton opened this issue Aug 27, 2024 · 3 comments · May be fixed by #5361
Closed

Make sure the janitor does not spam the metastore too much #5353

fulmicoton opened this issue Aug 27, 2024 · 3 comments · May be fixed by #5361
Assignees
Labels
bug Something isn't working

Comments

@fulmicoton
Copy link
Contributor

In #5346 we have spotted that our implementation of delete index was too aggressive.

For airmail, their internal job deleting a large number of indexes ended up hammering the metastore, hence disrupting indexing.

We want to make sure that we don't have a similar pattern in the janitor. In particular, when running the retention policy.

@fulmicoton fulmicoton added the bug Something isn't working label Aug 27, 2024
@fulmicoton
Copy link
Contributor Author

(@trinity-1686a maybe there is not problem... If so, please just comment here and close the ticket)

@trinity-1686a
Copy link
Contributor

there is definitely a problem here. Last i checked, the retention policy is executed on a strict cron-like schedule. If many indexes share the same schedule frequency, they would all run at once (technically, one after the other in quick succession, as fast as possible). Right now based on airmail logs, it seems we run roughly 20k retention policies all at once.

@trinity-1686a
Copy link
Contributor

we also seem to execute all GC calls at once, but scoping them by index, which causes many consecutive call, and much more often (every 10 or so minutes). That's something that can also be improved upon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants