Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove actioncable imported code #10

Closed
sirwolfgang opened this issue Apr 11, 2023 · 2 comments · Fixed by #276
Closed

Remove actioncable imported code #10

sirwolfgang opened this issue Apr 11, 2023 · 2 comments · Fixed by #276
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@sirwolfgang
Copy link
Member

Due to some build issues, we imported the action cable code; The fixes should be unstreamed, so that we can reduce the maintenance risk of this part of the code.

@rubendinho
Copy link
Member

@sirwolfgang This may be related to: #96

I believe all the Apollo stuff should be moved from @quiltt/core to @quiltt/react. @apollo/client is a React package, and also adds unnecessary dependencies to the non-React core JS package.

@sirwolfgang
Copy link
Member Author

@apollo/client is not a react client, it has things to support a react client. https://github.com/apollographql/apollo-client/blob/main/package.json#L66-L86

Anything that an express/node server could also make use of should be in core; but notably a express/node package would also inherent from core.

@rubendinho rubendinho added the dependencies Pull requests that update a dependency file label Dec 14, 2023
@rubendinho rubendinho self-assigned this Jul 13, 2024
@rubendinho rubendinho linked a pull request Jul 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants