From 771cda22ab8ac703337d28d1a07ddf2c037feac5 Mon Sep 17 00:00:00 2001 From: Ruben Izmailyan Date: Thu, 14 Nov 2024 08:56:21 -0600 Subject: [PATCH 1/2] Fix types --- packages/core/src/api/browser.ts | 15 ++++++++++----- packages/react/src/hooks/useQuilttConnector.ts | 11 ++++++----- 2 files changed, 16 insertions(+), 10 deletions(-) diff --git a/packages/core/src/api/browser.ts b/packages/core/src/api/browser.ts index fa327268..dc821c81 100644 --- a/packages/core/src/api/browser.ts +++ b/packages/core/src/api/browser.ts @@ -115,13 +115,11 @@ export type ConnectorSDKCallbackMetadata = { /** Options for the standard Connect flow - @param institution The Institution search term or ID to preload + @param institution The Institution ID or search term to connect */ export type ConnectorSDKConnectOptions = ConnectorSDKCallbacks & { - /** The Institution search term or ID to preload */ + /** The Institution ID or search term to connect */ institution?: string - /** The ID of the Connection to reconnect */ - connectionId?: string } /** @@ -134,4 +132,11 @@ export type ConnectorSDKReconnectOptions = ConnectorSDKCallbacks & { } /** Options to initialize Connector */ -export type ConnectorSDKConnectorOptions = ConnectorSDKConnectOptions | ConnectorSDKConnectOptions +// @todo: refactor into a union type - it's either or. +export type ConnectorSDKConnectorOptions = ConnectorSDKCallbacks & { + /** The Institution ID or search term to connect */ + institution?: string + + /** The ID of the Connection to reconnect */ + connectionId?: string +} diff --git a/packages/react/src/hooks/useQuilttConnector.ts b/packages/react/src/hooks/useQuilttConnector.ts index de893c1c..517edf8d 100644 --- a/packages/react/src/hooks/useQuilttConnector.ts +++ b/packages/react/src/hooks/useQuilttConnector.ts @@ -2,11 +2,12 @@ import { useCallback, useEffect, useState } from 'react' -import { - type ConnectorSDK, - type ConnectorSDKConnector, - type ConnectorSDKConnectorOptions, - cdnBase, +import { cdnBase } from '@quiltt/core' + +import type { + ConnectorSDK, + ConnectorSDKConnector, + ConnectorSDKConnectorOptions, } from '@quiltt/core' import { version } from '../version' From 8768b181be8b13cb95e5fa14aac30f9bd289d520 Mon Sep 17 00:00:00 2001 From: Ruben Izmailyan Date: Thu, 14 Nov 2024 09:01:36 -0600 Subject: [PATCH 2/2] Add changelog --- .changeset/smart-lamps-relate.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/smart-lamps-relate.md diff --git a/.changeset/smart-lamps-relate.md b/.changeset/smart-lamps-relate.md new file mode 100644 index 00000000..5ab078d6 --- /dev/null +++ b/.changeset/smart-lamps-relate.md @@ -0,0 +1,7 @@ +--- +"@quiltt/react-native": patch +"@quiltt/react": patch +"@quiltt/core": patch +--- + +Fix typings