Skip to content

Commit

Permalink
[WIP] Build: Try adding back old iOS/Android to BS matrix
Browse files Browse the repository at this point in the history
* Drop support for Android 4-6, and Android Browser,
  require Android 7.0+ which can run Chrome 80.

* Drop support for iOS 7-8,
  require iOS 9+ (we already require Safari 9 for macOS).
  • Loading branch information
Krinkle committed Jul 8, 2024
1 parent bf1406e commit aa0bd6f
Show file tree
Hide file tree
Showing 5 changed files with 64 additions and 30 deletions.
48 changes: 48 additions & 0 deletions .github/workflows/browsers-debug.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
name: browsers-debug
on:
# Or manually
workflow_dispatch:
# Or when developing this workflow
push:
paths:
- .github/workflows/browsers-debug.yaml
- build/browserstack-debug.json

jobs:
run:
name: BrowserStack
if: ${{ github.repository == 'qunitjs/qunit' }} # skip on forks, needs secret
runs-on: ubuntu-latest
env:
PUPPETEER_DOWNLOAD_PATH: "${{ github.workspace }}/.puppeteer_download"
steps:
- uses: actions/checkout@v4

- uses: actions/cache@v4
with:
path: |
~/.npm
${{ github.workspace }}/.puppeteer_download
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}

- name: Use Node.js 18
uses: actions/setup-node@v4
with:
node-version: 18.x

- name: Prepare
run: |
npm ci
npm run build
- name: Tests
run: npm run browserstack
env:
BROWSERSTACK_JSON: build/browserstack-debug.json
BROWSERSTACK_USERNAME: "${{ secrets.BROWSERSTACK_USERNAME }}"
BROWSERSTACK_KEY: "${{ secrets.BROWSERSTACK_KEY }}"
# Set "project" metadata
TRAVIS_REPO_SLUG: "${{ github.repository }} ${{ github.event_name }}"
# Set "commit" metadata
TRAVIS_COMMIT: "full ${{ github.ref }} ${{ github.sha }}"
TUNNEL_ID: "${{ github.event_name }}-full-${{ github.sha }}"
1 change: 1 addition & 0 deletions .github/workflows/browsers-full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
push:
paths:
- .github/workflows/browsers-full.yaml
- build/browserstack-full.json

jobs:
run:
Expand Down
39 changes: 13 additions & 26 deletions build/browserstack-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,41 +40,28 @@
"os_version": "10.0"
},
{
"device": "iPhone 8",
"real_mobile": true,
"os": "ios",
"os_version": "12"
}
],
"@browsers_disabled": [
{
"@ref": [
"https://github.com/browserstack/browserstack-runner/issues/245",
"Android 4, Android 5, Android 6"
]
"os": "android",
"os_version": "7.0",
"device": "Samsung Galaxy S8",
"real_mobile": true
},
{
"@ref": [
"https://github.com/browserstack/browserstack-runner/issues/226",
"Android 7-10",
"iOS 13, 14"
]
"os": "ios",
"os_version": "11.0"
},
{
"device": "Samsung Galaxy S7",
"real_mobile": true,
"os": "android",
"os_version": "6.0"
"os": "ios",
"os_version": "10.3"
},
{
"device": null,
"os": "ios",
"os_version": "13"
},
"os_version": "9.3"
}
{
"device": null,
"device": "iPhone 8",
"real_mobile": true,
"os": "ios",
"os_version": "14"
"os_version": "12"
}
]
}
2 changes: 1 addition & 1 deletion src/core/utilities.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export function objectValuesSubset (obj, model) {
return subset;
}

// Support: IE 11, iOS 7-8
// Support: IE 11
export function extend (a, b, undefOnly, allProperties) {
for (const prop in b) {
if (hasOwn.call(b, prop) || allProperties) {
Expand Down
4 changes: 1 addition & 3 deletions src/globals.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,7 @@ export const sessionStorage = (function () {
}
}());

// Basic fallback for ES6 Map
// Support: Safari 7; Map is undefined
// Support: iOS 8; `new Map(iterable)` is not supported
// Basic fallback for ES6 Map and `new Map(iterable)`
//
// Fallback for ES7 Map#keys
// Support: IE 11; Map#keys is undefined
Expand Down

0 comments on commit aa0bd6f

Please sign in to comment.