Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support periodic boundary conditions for self-gravity #700

Open
BenWibking opened this issue Aug 2, 2024 · 2 comments · May be fixed by #703
Open

support periodic boundary conditions for self-gravity #700

BenWibking opened this issue Aug 2, 2024 · 2 comments · May be fixed by #703
Labels
enhancement New feature or request

Comments

@BenWibking
Copy link
Collaborator

Describe the proposal
We currently only support open boundary conditions for the Poisson equation using the amrex::OpenBC Poisson solver. We can also use amrex::MLMG to do the Poisson solve for periodic BCs.

Describe alternatives you've considered
N/A

Additional context
Needed for cosmological PopIII stars.

@BenWibking BenWibking added the enhancement New feature or request label Aug 2, 2024
@BenWibking BenWibking linked a pull request Aug 4, 2024 that will close this issue
7 tasks
@BenWibking
Copy link
Collaborator Author

BenWibking commented Dec 12, 2024

@markkrumholz IMO this could be another good intermediate project to tackle before adding AMR subcycling support to the gravity solver, since using the amrex::MLMG class will be necessary for the Poisson solves on all refined AMR levels.

@markkrumholz
Copy link
Collaborator

@lizmcole, @BenWibking: that does sounds like a good idea, and a necessary step before going to adaptive time stepping anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants