Fixup/sqlserver datetime2 #885
Merged
+101
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonpcouch
approved these changes
Jan 27, 2025
src/nanodbc/nanodbc.cpp
Outdated
| describe_parameters(param_index); | ||
| const SQLSMALLINT& param_type = param_descr_data_.at(param_index).type_; | ||
| NANODBC_ASSERT(param_type < static_cast<SQLULEN>(std::numeric_limits<short>::max())); | ||
| return static_cast<unsigned long>(param_type); |
There was a problem hiding this comment.
This may just be my C++ naïveté—apologies if so. From what I can tell, the function declares it returns a short but can actually return an unsigned long. Is this ever an issue?
There was a problem hiding this comment.
Good call and thank you for taking a look!
The compiler will clean that up and cast back to short, but its poor form on my part. Fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #793
This is a long standing issue where we were forcing a precision of 3 for all DATETIME types despite some ( for example DATETIME2 ) having potentially greater precision.
Requires a backport from nanodbc.