use safer math.js compile/evaluate to eval user arith expressions #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yeedle ! After a bit of struggling with some manual conflict resolving, I've managed to get this PR into master. It seems to work like a charm, so again, thanks a bunch for all your efforts!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment in my original PR #31 (comment). This PR addresses #29
In this PR, I added a cache for expression. On first encounter, the expression is compiled into a JavaScript function using math.js's
compile, and on subsequent calls, theevalMathfunction will used the compiled function rather than recompile every time. In theory this should be even faster than using the built inevalorFunction. In practice it's probably the same.Check it out and let me know what you think!