Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for newly installed QGIS version #94

Closed
florisvdh opened this issue Feb 28, 2022 · 2 comments · Fixed by #110
Closed

Checking for newly installed QGIS version #94

florisvdh opened this issue Feb 28, 2022 · 2 comments · Fixed by #110

Comments

@florisvdh
Copy link
Member

florisvdh commented Feb 28, 2022

After upgrading QGIS 3.22 to 3.24, the cache is not updated and one still gets (on Linux Mint 20):

> library(qgisprocess)
Using 'qgis_process' at '/usr/bin/qgis_process'.
QGIS version: 3.22.3-Białowieża
Configuration loaded from '~/.cache/R-qgisprocess/cache-0.0.0.9000.rds'
Run `qgis_configure()` for details.
Using JSON for output serialization

When loading qgisprocess, it would probably be best to always check whether a new QGIS version is installed compared to the cached version, before loading the cache. In case of a new version, the cache is to be refreshed (by running qgis_configure()). And in that case, GRASS and SAGA providers (and perhaps other plugins), if they're available, could be enabled if not already so (see #93), before running the reconfiguration.

@paleolimbot
Copy link
Collaborator

Good point! On MacOS the path changes for most version updates, so I didn't catch it. The current trigger for the cache is:

https://github.com/paleolimbot/qgisprocess/blob/master/R/qgis-configure.R#L101

...but should probably be rlang::hash(list(<all the things that should trigger an update>))

@florisvdh
Copy link
Member Author

A proposed fix (cache rebuilding) is in PR #110, which also gives some feedback to the user about changed QGIS version or path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants