Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Pepto" colour palette incorrect #10

Open
vonmillhausen opened this issue Nov 27, 2023 · 0 comments
Open

"Pepto" colour palette incorrect #10

vonmillhausen opened this issue Nov 27, 2023 · 0 comments

Comments

@vonmillhausen
Copy link

In /Src/Display.cpp lines 97 to 110, the "Pepto" colour palette is defined; however, there are two problems with it:

  1. The "Pepto" colour palette has long since been succeeded by the more accurate "Colodore" palette, also by Philip "Pepto" Timmermann
  2. The colours defined in the Frodo source code don't match either of the "Pepto" or "Colodore" palettes, and are just plain wrong

I suggest the code be updated to the below, which will change it to the current community-accepted Colodore palette instead (and update the comment to make it clear that the palette being used is "Colodore" and not "Pepto", both of which are discussed on the linked page):

// C64 "Colodore" color palette
// Values based on measurements by Philip "Pepto" Timmermann <[email protected]>
// (see https://www.pepto.de/projects/colorvic/)
const uint8 palette_red[16] = {
	0x00, 0xff, 0x81, 0x75, 0x8e, 0x56, 0x2e, 0xed, 0x8e, 0x55, 0xc4, 0x4a, 0x7b, 0xa9, 0x70, 0xb2
};

const uint8 palette_green[16] = {
	0x00, 0xff, 0x33, 0xce, 0x3c, 0xac, 0x2c, 0xf1, 0x50, 0x38, 0x6c, 0x4a, 0x7b, 0xff, 0x6d, 0xb2
};

const uint8 palette_blue[16] = {
	0x00, 0xff, 0x38, 0xc8, 0x97, 0x4d, 0x9b, 0x71, 0x29, 0x00, 0x71, 0x4a, 0x7b, 0x9f, 0xeb, 0xb2
};

I would also further suggest updating lines 37 to 39 in the same file to the following, just for consistency:

#define USE_COLODORE_COLORS 1

#ifdef USE_COLODORE_COLORS
madcock added a commit to madcock/libretro-frodo that referenced this issue Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant