Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rustc 1.70 and/or control of rust toolchain? #268

Closed
tshauck opened this issue Jul 6, 2023 · 12 comments
Closed

Support for rustc 1.70 and/or control of rust toolchain? #268

tshauck opened this issue Jul 6, 2023 · 12 comments

Comments

@tshauck
Copy link

tshauck commented Jul 6, 2023

Hi,

Thanks for providing this resource. I was hoping to publish a rust based R package however I'm running into challenges that a dependency of my rust package clashes with the installed rustc on the builder, so I'm getting:

error: package `half v2.3.1` cannot be built because it requires rustc 1.70, while the currently active rustc version is 1.65.0

half is used by the arrow rust package.

I think there are workarounds, but the selfishly the easiest would be to have the ability to use 1.70, either installed on the builder or the ability to manage w/ rustup.

If there's a different solution you'd recommend, I'd certainly be open to that too. Thanks!

Failed build for context

@jeroen
Copy link
Member

jeroen commented Jul 7, 2023

Hmm we use the ppa from mozilla which again I think is mostly ported from the latest rust on debian which is currently 1.66.

Perhaps we should switch to the upstream rustup although I really wish rust crate authors would make some effort supporting the mainstream stable rust versions out there, instead of requiring a bleeding edge version...

@tshauck
Copy link
Author

tshauck commented Jul 7, 2023

Ha, I certainly can sympathize with this after the last week of package updates. FWIW, I think it might cultural differences between the communities. E.g. rustup being from the language team and 1.70 being stable vs beta or the nightly build.

image

If you'd be willing to try putting rustup on runners, I'd certainly be happy to help test.

@jeroen
Copy link
Member

jeroen commented Jul 7, 2023

OK I'll try switching, see if this breaks other packages...
r-universe-org/base-image#4

@tshauck
Copy link
Author

tshauck commented Jul 7, 2023

Ok, thanks. I'll give it a look this afternoon (~5 hrs from now) and follow up.

@tshauck
Copy link
Author

tshauck commented Jul 7, 2023

Looks like you may've seen this, but there looks to be an issue that the install process assumes cargo exists on the path, but it does not yet. I've updated the makevars file in my repo to run rustup update which at least locally and on non-r-universe action builds seems to run as expected. I'll check on the r-universe build next time it's triggered.

@jeroen
Copy link
Member

jeroen commented Jul 7, 2023

There seems to be a problem because rustup installs in the user HOME dir, but github-actions overrides the user HOME with a path from the host.

@tshauck
Copy link
Author

tshauck commented Jul 7, 2023

Yerp... seeing 90ec5dfc0882ecbc5c6091f4abd1f42b680aa9a3 🤞... thanks for working on this

@jeroen
Copy link
Member

jeroen commented Jul 7, 2023

OK this should be fixed. Now your package fails with another problem 😁 https://github.com/r-universe/wheretrue/actions/runs/5490134880/jobs/10007164366

@jeroen jeroen closed this as completed Jul 7, 2023
@tshauck
Copy link
Author

tshauck commented Jul 7, 2023

Onward -- thanks!

@jeroen
Copy link
Member

jeroen commented Jul 8, 2023

Could you also associate your maintainer emaill address [email protected] with your github account? See https://github.com/r-universe-org/help#how-to-link-a-maintainer-email-addresses-to-a-username-on-r-universe

@eitsupi
Copy link

eitsupi commented Jul 8, 2023

half is used by the arrow rust package.

Since arrow-rs specifies 1.62 on the Cargo.toml, this may be better discussed in this issue apache/arrow-rs#181.
https://github.com/apache/arrow-rs/blob/aac3aa99398c4f4fe59c60d1839d3a8ab60d00f3/Cargo.toml#L76

@tshauck
Copy link
Author

tshauck commented Jul 8, 2023

@jeroen I've associated the email.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants