Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to edit an existing release instead of uploading new #24

Open
chrismclarke opened this issue Sep 16, 2020 · 9 comments
Open

Ability to edit an existing release instead of uploading new #24

chrismclarke opened this issue Sep 16, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@chrismclarke
Copy link

chrismclarke commented Sep 16, 2020

Would it be possible to add the ability to edit an existing release via action instead of uploading? I'm wondering if this might be as simple as running the script without a release file (removing the required field)?

A use case for this would be workflows where the action on one github branch submits a release to internal testing, and then another branch/release could be used to promote the same release to beta or production tracks.

(found this stackoverflow article which seems to think it's possible https://stackoverflow.com/questions/49588393/promoting-beta-apk-to-production-programmatically)

@r0adkll r0adkll self-assigned this Nov 11, 2020
@r0adkll r0adkll added the enhancement New feature or request label Nov 11, 2020
@r0adkll
Copy link
Owner

r0adkll commented Nov 11, 2020

That definitely seems feasible per the docs: https://developers.google.com/android-publisher/tracks, where I can update a release and specify a track to move it to. I will look into implementing this.

@boswelja
Copy link
Collaborator

I think things like changing status from inProgress to completed or halted could be separate actions, since this action is targeted at uploading APK/AAB to Google Play. It shouldn't be too difficult to allow passing in an Edit ID for uploading new builds to an existing edit, and we can totally expose the edit ID as an output field. Any thoughts @chrismclarke ?

@boswelja
Copy link
Collaborator

fwiw I do already have an action to promote open testing to production here: https://github.com/boswelja/promote-play-beta-action
It doesn't have much flexibility right now, but if it's something people are interested in I can make some changes to accommodate more configurations :)

@chrismclarke
Copy link
Author

I think splitting the functionality for uploading new release to a track vs promoting from one track to another makes a lot of sense to me, I think the action you've created sounds near ideal (guessing would just need to expose options for source and target tracks instead of hardcoded beta/production).

For now I've found ways around this on the projects I needed it for, but good to know that's an option - thanks for letting me know about it @boswelja.

@boswelja
Copy link
Collaborator

Perfect, I'll look into passing an existing edit ID in to this action + exposing tracks for promotion in my other action. Thanks for your input!

@boswelja
Copy link
Collaborator

As of #120 we can pass in an edit ID to avoid creating a new edit every time. Still a few things needed before we can truly edit existing edits, namely

  • Outputting the edit ID
  • Add an option to prevent publishing edits

@abhi250401
Copy link

where can i get this edit ID ?

@petros-chariskos
Copy link

Some action here is more than welcome!

@boswelja
Copy link
Collaborator

where can i get this edit ID ?

From anywhere that outputs it (you can also make the API calls yourself). I'm not sure what else to say?

Some action here is more than welcome!

You are welcome to open a pull request 😄

To reiterate, we still need

  • A means of preventing edit commits
  • A means of outputting the edit ID, when the edit was not committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants