Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension crashes when switching to reader mode #156

Open
IkelAtomig opened this issue Jan 8, 2023 · 5 comments
Open

Extension crashes when switching to reader mode #156

IkelAtomig opened this issue Jan 8, 2023 · 5 comments

Comments

@IkelAtomig
Copy link

As title say, it does. I need to reload the page and click again to switch to reader mode.

The crash happens. When the page is newly loaded and you try to switch to reader mode.

@IkelAtomig IkelAtomig changed the title Extension crashes when clicking on it Extension crashes when switching to reader mode Jan 8, 2023
@rNeomy
Copy link
Owner

rNeomy commented Jan 8, 2023

Is this on Chrome? What is the browser version?

@IkelAtomig
Copy link
Author

This happens on Brave with latest version. Chromium 108 and Windows 11.

Head to https://techcrunch.com/2022/12/30/inside-matrix-the-protocol-that-might-finally-make-messaging-apps-interoperable/?guccounter=2

Load the page. Click the extension in toolbar. It won't switch to reader view. Either it crashes or you need to reload and to enter to reader mode.

https://www.theguardian.com/technology/2022/dec/08/twitter-sued-firing-female-workers-after-musk-buyout

Go to above page and hit the extension twice in Addressbar. You will see it as crashed.

@rNeomy
Copy link
Owner

rNeomy commented Jan 9, 2023

It seems that this may be an issue with the worker. I was unable to replicate the issue. However, in the updated version of the extension, IndexedDB is being used to store temporary reader objects, which may resolve the issue. Please let me know once you have received the update.

@IkelAtomig
Copy link
Author

image

This is what happens when I click the extension after the new update it doesn't change to reader mode. Literally broken.

@IkelAtomig
Copy link
Author

Well, The extension seems to load pages smoothly at times. But at certain times. It crashes. Need to reload page and switch to the reader view.

Would be better to have smoother transitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants