Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue Diode in non-linear components menu can't change it's symbol #1117

Closed
tomhajjar opened this issue Dec 4, 2024 · 7 comments · Fixed by #1190
Closed

Blue Diode in non-linear components menu can't change it's symbol #1117

tomhajjar opened this issue Dec 4, 2024 · 7 comments · Fixed by #1190
Labels

Comments

@tomhajjar
Copy link

Blue Diode in non-linear components menu can't change it's symbol anymore.

Should the Red diode also have symbol options?

2024-12-03_231354

@iwbnwif
Copy link
Contributor

iwbnwif commented Dec 4, 2024

This is a result of 782f592 and is because some 'components' set certain property names to symbol in order to mask them.

I need to work out which components mask properties in that way and only hide the symbol entry in those instances.

@tomhajjar
Copy link
Author

tomhajjar commented Dec 4, 2024

I never tried the "Populate parameters..." with the Blue diode so I didn't previously test it. I did in the attached.

  1. The Blue "Qucs" diode parameters don't match 1:1 with the ngspice diode parameters. What happens to the "un-used" parameters? I assume this diode only work with ngspice. If the schematic is opened in "qucsator" mode, does this "Blue" diode trigger an error?

  2. The Red "Spice" diode can be assigned parameters that ngspice doesn't support but it's OK because ngspice flags and ignores them.

  3. Why wasn't the Red diode given the "Populate parameters..." feature? Can Red diode also have symbol options? Today you have to make a sub-circuit and give it the desired symbol.

Rectifiers_prj.zip

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2024

I assume this diode only work with ngspice.

Blue diode works with all simulation kernels. The incompatible parameters are ingnored while doing neltisting. The #974 will hide incompatible parameters from user. The Red diode cannot be even inserted in Qucsator mode.

Why wasn't the Red diode given the "Populate parameters..." feature?

This diode was designed to copy-paste the modelcard as is. This device is also needed for microelectronics PDKs. The Fill from SPICE option should be available only for blue devices.

@ra3xdh ra3xdh added the bug label Dec 4, 2024
@tomhajjar
Copy link
Author

tomhajjar commented Dec 4, 2024

@iwbnwif

One requirement of "Blue" devices is the Reference Designation starts with a "fixed" Letter like "D" for the Diode and SHOULD have an underscore "_" at the end for proper device numbering.

A new User wouldn't know this. I wonder if a note should be in the device pop-up window?

2024-12-04_122716

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2024

One requirement of "Blue" devices is the Reference Designation starts with a "fixed" Letter like "D"

All blue devices handle the SPICE letter automatically. The correct letter will be assigned automatically regardless the device name. User doesn't need to add the "D" letter. See the spice_netlist method in the source code. The modification of the netlister is not required.

@ra3xdh
Copy link
Owner

ra3xdh commented Dec 4, 2024

I propose don't fix this issue at the moment and wait for the implementation of #974. This will bring a fix for this automatically. I will start to work on #974 in January.

@ra3xdh
Copy link
Owner

ra3xdh commented Jan 6, 2025

I have no time to implement the #974 before the release, so I decided to add a temporary fix for this issue. See #1190

ra3xdh added a commit that referenced this issue Jan 6, 2025
Temporary fix for #1117 and upload CD4069 model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants