-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spice Library device cannot process nested subcircuits #1120
Comments
The netlist contains the nested subcircuits. This syntax was not allowed by Ngspice in the past and Ngspice showed a warning and even may fail the simulation with the convergence error. Has something changed in the recent versions? |
Unsure when ngspice allowed nested sub-circuits. The vco subcircuit "vco_sub.cir" has been in the ngspice XSPICE examples folder for a VERY long time. It is so old it was replaced by "vco_sub_new.cir' and hasn't been used for many releases of ngspice. It's actually an "orphan" subcircuit that was left in the folder. "vco_sub_new.cir' uses the ngspice "exclusive" "d_osc" function. I would need to ask Holger when nested sub-circuits were allowed. C:\Ngspice-43+_64\examples\xspice\pll Turns out "d_osc" has a bug which explains why it's been driving me crazy... ;-) |
I downloaded ngspice 25 from 2013 and the "vco_sub.cir" dated 2012 is identical and still has nested subcircuits... |
Fixed by #1211 |
Spice library is "confused" trying to "process" VCO_MOS_sub.cir. It doesn't like the three subcircuits in the middle.
Subcircuit .subckt ro_vco
sub 1
sub 2
sub 3
.ends ro_vco
Spice netlist gets processed by ngspice which works.
PLL_XSPICE_prj.zip
The text was updated successfully, but these errors were encountered: