Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry icons on HiDPI #304

Closed
7 of 8 tasks
hugolundin opened this issue Aug 22, 2023 · 15 comments · Fixed by #323 or #334
Closed
7 of 8 tasks

Blurry icons on HiDPI #304

hugolundin opened this issue Aug 22, 2023 · 15 comments · Fixed by #323 or #334
Assignees
Milestone

Comments

@hugolundin
Copy link

hugolundin commented Aug 22, 2023

Icons are blurry when using macOS with High DPI (Retina). See the attached image (click to open the image in full screen to really see how they look).

Screenshot 2023-08-22 at 10 08 21

It seems like Qt should have means for solving this: https://doc.qt.io/qt-6/highdpi.html

TODO from @ra3xdh :

  • Update toolbar icons (replace by SVG); design 8 original icons Svg icons #323
  • Implement automatic generation of high-resolution components icons Render icons #334
  • Redesign diagram icons (11 icons); these icons cannot be generated automatically;
  • Redesign paintings icons (8 icons)
  • Redesign simulation icons
  • Redesign file devices and equations icons
  • Redesign icons for SPICE specific section
  • Process all SVG images with SVG optimizer https://github.com/svg/svgo
@ra3xdh
Copy link
Owner

ra3xdh commented Aug 22, 2023

Yes, I am aware about issues with icons. The same appears using KDE on Linux and display scaling.

image

The icons in the Qucs-S are designed as fixed resolution 22x22 PNG bitmaps. These icons still be inherited from Qt3 version. And this will look poor when using HiDPI resolution. The only solution for this issue is to redesign all button icons located in qucs/bitmaps. The usage of the SVG icons would be also good. But this task cannot be done in the near future because of need to redraw all icons. I am programmer, but not a graphical designer and cannot perform this task by myself. The contribution is highly welcome here.

Summarizing all above, don't expect the icons to be fixed in the near years, unless someone will redesign the icons and propose a PR.

@ra3xdh ra3xdh changed the title Blurry icons on macOS Blurry icons on HiDPI Aug 22, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 15, 2023

I have started to replace toolbar icons by standard SVG icons from KDE Oxygen theme. This icon set should look good for both dark and light desktop themes. The most of toolbar icons could be replaced by standard icons. But 9 icons should be designed from scratch. Probably Oxygen icons could be used as template. I have uploaded updated icons to the svg_icons branch: https://github.com/ra3xdh/qucs_s/tree/svg_icons

I don't consider the redesign of components icons because a huge amount of work.

image

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 16, 2023

I have finished update of the toolbar icons. The result could be seen on the screenshot. I am planning to include updated icons in the next release. The following tasks are remaining:

  • It's need to implement automatic generation of the component icons. This will allow to avoid redesign of more than 100 icons.
  • The diagram icons cannot be generated automatically. These 11 icons should be redrawn by hand.

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 16, 2023

Here is the new toolbar look:
image

@ra3xdh ra3xdh mentioned this issue Oct 16, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 16, 2023

See #323

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 17, 2023

I have added update for toolbar and dialog icons. The automatic generation of component icons will be added later. Issue still open.

@ra3xdh ra3xdh reopened this Oct 17, 2023
@ra3xdh ra3xdh mentioned this issue Oct 18, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 18, 2023

See #332 for diagram and paintings icons

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 19, 2023

I have updated diagram icons. Here is the new application look. It is not possible to update remaining 250+ device icons manually. Automatic icons generator need to be implemented.
image

@ra3xdh ra3xdh self-assigned this Oct 20, 2023
@ra3xdh ra3xdh added this to the 2.0.1 milestone Oct 20, 2023
@ra3xdh ra3xdh mentioned this issue Oct 20, 2023
@ra3xdh
Copy link
Owner

ra3xdh commented Oct 20, 2023

See #334 for icons rendering. Here is the new application look.
image

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 20, 2023

New auto-generated icons after adjustment.
image

@hugolundin
Copy link
Author

Amazing work!

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 21, 2023

Resolved with #332 and #334. New icons will be available since the next release. I have no possibility to check everything with 4k resolution hardware, but everything works fine using fullHD and scaling applied.

@hugolundin
Copy link
Author

I can do a sanity check on my retina Mac later next week. But this seems fantastic, great job!

@hugolundin
Copy link
Author

Screenshot 2023-10-23 at 23 03 43

The icons look great on my Macbook Air (with scaled resolution) now! Thank you!

@ra3xdh
Copy link
Owner

ra3xdh commented Oct 24, 2023

@hugolundin Thanks for testing on MacOS! I am planning to prepare the release packages by the end of this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants