Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos build failed with qucsator_rf #712

Closed
dsm opened this issue May 5, 2024 · 12 comments · Fixed by #720
Closed

macos build failed with qucsator_rf #712

dsm opened this issue May 5, 2024 · 12 comments · Fixed by #720

Comments

@dsm
Copy link
Collaborator

dsm commented May 5, 2024

Hi, I'am developing to github action to build mac version of qucs but macos build failed with qucsator_rf. error is related to VERSION file like old issue on windows MSVC build.

OS: Macos 14.4.1 arm64

@ra3xdh
Copy link
Owner

ra3xdh commented May 6, 2024

It's need to exclude the toplevel directory from include directories list. This directory doesn't contain header files. It's need to look for old commits fixing this issue for Qucs GUI and apply the similar patch for qucsator_rf.

Are you planning to add Github action for Windows too or for MacOS only? Windows support has higher priority than MacOS.

@dsm
Copy link
Collaborator Author

dsm commented May 6, 2024

I'm thinking of adding it for windows and macos. I can add windows support earlier.

I've been experimenting with it since i just got a new macbook.

i'm running out of time for this week. i'm thinking of speeding it up in the coming weeks.

Which installer do you prefer for the windows side installation file (ex. NSIS installer)

@ra3xdh
Copy link
Owner

ra3xdh commented May 6, 2024

Yes, the Windows Github action would be useful. I am using MSYS2 to build binaries and InnoSetup to generate the installer. Here is my InnoSetup script template: https://github.com/ra3xdh/qucs_scripts/blob/master/qucs.iss

@dsm
Copy link
Collaborator Author

dsm commented May 6, 2024

Thank you, github action has native windows-2022 server runner maybe using for msvc build. msys2 for building mingw variant.

@dsm
Copy link
Collaborator Author

dsm commented May 6, 2024

I think qucsator_rf cmake file need refactoring and flex,bison,gperf,dos2unix,sed all of this needed I don't know why. Can you explain ?

@ra3xdh
Copy link
Owner

ra3xdh commented May 6, 2024

I think qucsator_rf cmake file need refactoring

I don't recommend a deep refactoring of qucsator-related CMake stuff. Maybe restrict to fixing warnings from modern CMake and revert autotest stuff: https://github.com/Qucs/qucs-test This work definitely should go to the separate PR from Github actions.

flex,bison,gperf,dos2unix,sed all of this needed I don't know why

  • Flex/Bison are needed to generate a parsers for different netlists
  • Gperf generates some syntax analyzer tables. I don't know why the developers of Qucsator decided to use Gperf for this purpose.
  • Dos2unix is needed to postprocess the files generated by gperf. Otherwise build fails on some platfroms.
  • Sed is also needed for postprocessing of the files generated by gperf.

@dsm
Copy link
Collaborator Author

dsm commented May 6, 2024

I am not able to build native Windows 10 build gperf in path but gperfappgen.exe note found error i didn't found this exe.

cmake minimum maybe be increased to 3.10 and some compiler flag set using modern cmake

@ra3xdh
Copy link
Owner

ra3xdh commented May 6, 2024

I recommend to use MSYS2 environment to build qucsator_rf. It is deeply integrated with Unix shell and there may be difficulties with build using native Windows shell. gperfappgen.exe is build by GCC from the CPP files from gperfappgen.exe. It generates input tables for gperf. The EXE could be found somewhere in build directory.

@dsm
Copy link
Collaborator Author

dsm commented May 6, 2024

I'll try MSYS2 for build, thank you

@ra3xdh
Copy link
Owner

ra3xdh commented May 6, 2024

Here is Github MSYS2 workflow template: https://github.com/msys2/setup-msys2

@dsm
Copy link
Collaborator Author

dsm commented May 6, 2024

ra3xdh/qucsator_rf#3 will be fixed this issue.

@ra3xdh
Copy link
Owner

ra3xdh commented May 7, 2024

I have accepted ra3xdh/qucsator_rf#3 and updated qucsator_rf submodule.

@ra3xdh ra3xdh closed this as completed May 8, 2024
@ra3xdh ra3xdh linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants