Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable redundant checks in CMake #10

Closed
ra3xdh opened this issue Jul 4, 2024 · 1 comment · Fixed by #12
Closed

Disable redundant checks in CMake #10

ra3xdh opened this issue Jul 4, 2024 · 1 comment · Fixed by #12
Assignees
@ra3xdh
Labels
cmake

Comments

@ra3xdh
Copy link
Owner

ra3xdh commented Jul 4, 2024

See ra3xdh/qucs_s#796 for context. The CMake checks for mathematical functions that are part of cmath according C++11 standard. https://cplusplus.com/reference/cmath/ I think this check is redundant and may be disabled because CMake checks if C++11 is available at the same time.
@ra3xdh ra3xdh added the cmake label Jul 4, 2024
@ra3xdh ra3xdh self-assigned this Jul 4, 2024
@ra3xdh ra3xdh mentioned this issue Jul 4, 2024
Closed
@ra3xdh ra3xdh linked a pull request Jul 5, 2024 that will close this issue
Fix cmake search for fucntions #12
Merged
@ra3xdh ra3xdh closed this as completed in #12 Jul 5, 2024
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 5, 2024

Fixed by #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ra3xdh ra3xdh

Labels
cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cmake search for fucntions ra3xdh/qucsator_rf
1 participant
@ra3xdh