From 8da905dccb9b757e31ecaf7d1785dc11013eb580 Mon Sep 17 00:00:00 2001 From: Aitor Perez Cedres <1515757+Zerpet@users.noreply.github.com> Date: Mon, 4 Nov 2024 18:39:31 +0000 Subject: [PATCH 1/2] Fix API ref workflow Previously in build-test-publish, a step would commit an API reference to the wiki, for every commit. We have moved away from that practice, and that change broke this workflow. The simplest solution is to generate the Wiki page from the tag, as part of this workflow. --- .github/workflows/publish-versioned-api-ref.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-versioned-api-ref.yml b/.github/workflows/publish-versioned-api-ref.yml index 3dc413fd..d6b5aee4 100644 --- a/.github/workflows/publish-versioned-api-ref.yml +++ b/.github/workflows/publish-versioned-api-ref.yml @@ -26,11 +26,15 @@ jobs: repository: ${{ github.repository }}.wiki path: wiki + - name: Generate API reference + run: make -C messaging-topology-operator api-reference + - name: Push to wiki + # User and email as documented here: https://github.com/marketplace/actions/checkout#push-a-commit-using-the-built-in-token run: | cd wiki - git config --local user.email "github-actions@github.com" - git config --local user.name "github-actions" + git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com" + git config --local user.name "github-actions[bot]" # Add the versioned API Reference to the Wiki cp ../messaging-topology-operator/docs/api/rabbitmq.com.ref.asciidoc ./API_Reference_${{ steps.get_version.outputs.VERSION }}.asciidoc # Regenerate the ordered list of API Reference docs for the sidebar From 8d0cc5ea2bcff109f49fddcdb1b0e206ac9052e6 Mon Sep 17 00:00:00 2001 From: Aitor Perez Cedres <1515757+Zerpet@users.noreply.github.com> Date: Mon, 4 Nov 2024 18:42:28 +0000 Subject: [PATCH 2/2] Removed unused dev manifest generation This was left behind during the pruning of uploading to GCS, and Carvel package refactor. --- .github/workflows/build-test-publish.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/build-test-publish.yml b/.github/workflows/build-test-publish.yml index 193d14c8..1030cb36 100644 --- a/.github/workflows/build-test-publish.yml +++ b/.github/workflows/build-test-publish.yml @@ -138,8 +138,6 @@ jobs: kustomize edit set image \ rabbitmqoperator/messaging-topology-operator-dev=rabbitmqoperator/messaging-topology-operator:"${RELEASE_VERSION}" popd - make generate-manifests - echo -n "messaging-topology-operator-with-certmanager-${{ steps.meta.outputs.version }}.yaml" > "latest-topology-operator-dev-manifest.txt" - name: Upload operator manifests uses: actions/upload-artifact@v4