Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding connection Activities to RabbitMQActivitySource #1731

Open
eerhardt opened this issue Nov 22, 2024 · 1 comment
Open

Consider adding connection Activities to RabbitMQActivitySource #1731

eerhardt opened this issue Nov 22, 2024 · 1 comment
Assignees
Milestone

Comments

@eerhardt
Copy link
Contributor

Is your feature request related to a problem? Please describe.

It is hard to diagnose an application that is failing because its RabbitMQ server is unavailable, or an existing connection is terminated and reconnects start happening.

Describe the solution you'd like

In order to be able to diagnose connection problems in applications, we should add an Activity when a connection is attempted to be established, and set the exception on the Activity when it fails. This also applies to auto-recovering channels.

Describe alternatives you've considered

No response

Additional context

In .NET Aspire's RabbitMQ integration we added an Activity for each connection attempt when calling IConnectionFactory.CreateConnection. This allows developers to see the connection attempts in their telemetry sink (for example the .NET Aspire Dashboard).

It would be great if this was moved into the official RabbitMQ.Client library for all apps to be able to use, not just when using the .NET Aspire integration.

cc @lukebakken @stebet

@lukebakken lukebakken added this to the 7.1.0 milestone Nov 22, 2024
@lukebakken lukebakken self-assigned this Nov 22, 2024
@lukebakken
Copy link
Contributor

Feel free to open a PR, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants