Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

face* uses deprecated mzlib/kw #43

Open
LiberalArtist opened this issue Sep 20, 2018 · 1 comment
Open

face* uses deprecated mzlib/kw #43

LiberalArtist opened this issue Sep 20, 2018 · 1 comment

Comments

@LiberalArtist
Copy link
Contributor

Currently face* from pict/face is implemented with lambda/kw from the deprecated mzlib/kw, which is not compatible with #lang racket's keyword arguments.

I hope it would be ok to port pict/face (which actually re-exports the apparently undocumented module texpict/face) to modern Racket, and I would be happy to do that, but I don't know what the compatibility considerations are. If pict/face can't change, it seems important to note the non-standard calling convention in the documentation. (You can work around the current problem by writing e.g. (face* 'worried 'grimace 'frown '#:teeth? #t), where the keyword is quoted as an expression, which wouldn't work if pict/face used #lang racket.)

Additionally, looking at the implementation of face* revealed that only the first three by-position arguments are actually required: whatever the resolution to the keyword issue, this should be corrected in the documentation at the same time.

@rfindler
Copy link
Member

rfindler commented Jan 8, 2019

What about making the face function accept a keyword argument for each of those things (eyebrow-kind, mouth-kind, etc) and the mood argument determines what the default values for those optional keyword arguments are?

Then we don't really need face* at all and we can adjust the docs to deprecate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants