Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode lambda #1374

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Unicode lambda #1374

merged 5 commits into from
Nov 25, 2024

Conversation

NoahStoryM
Copy link
Contributor

@NoahStoryM NoahStoryM commented May 22, 2024

Checklist
  • Feature
  • documentation
  • test

Description of change

Add case-λ,case-λ:,pcase-λ:,pλ:,λ:,popt-λ:,opt-λ:.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add/change anything to legacy or compatibility libraries.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add/change anything to legacy or compatibility libraries.

If this file is not modified, an error will be reported (I forgot to record the specific error message).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/usr/share/racket/pkgs/typed-racket-compatibility/typed/scheme/base.rkt:20:22: module: identifier already required
  at: case-λ
  in: typed-racket/base-env/prims
  also provided by: scheme/base
  compilation context...:
   /usr/share/racket/pkgs/typed-racket-compatibility/typed/scheme/base.rkt
  location...:
   /usr/share/racket/pkgs/typed-racket-compatibility/typed/scheme/base.rkt:20:22
  context...:
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:700:0: compile-zo*
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:633:0: compile-zo*/cross-compile
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:449:15
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:435:12: build
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:406:0: maybe-compile-zo
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:210:0: compile-root
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:317:16
   /usr/share/racket/collects/compiler/private/cm-util.rkt:14:0: ormap-strict
   [repeats 4 more times]
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:210:0: compile-root
   /usr/share/racket/collects/compiler/private/cm-minimal.rkt:317:16
   /usr/share/racket/collects/compiler/private/cm-util.rkt:14:0: ormap-strict

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I read the wrong file in the reply, sorry!

@sorawee
Copy link
Contributor

sorawee commented Jul 2, 2024

@NoahStoryM do you still want to work on this? It appears there's an error in the latest commit.

@NoahStoryM
Copy link
Contributor Author

NoahStoryM commented Jul 5, 2024

@NoahStoryM do you still want to work on this? It appears there's an error in the latest commit.

Sorry, I just saw this reply now. I think the error is because it was tested with old version Racket (8.13.0.4), which does not define case-λ.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 2 files in this pull request and found no issues.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resyntax analyzed 2 files in this pull request and found no issues.

@NoahStoryM
Copy link
Contributor Author

@sorawee This PR has been open for a while, could you consider merging it?

@sorawee
Copy link
Contributor

sorawee commented Nov 21, 2024

I think @samth would be a good reviewer for this PR.

@samth samth merged commit 74bdc52 into racket:master Nov 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants