expose trackVerified() #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this out with Radar Verify, and it worked well. |
kochis
reviewed
Jul 28, 2023
src/index.ts
Outdated
| try { | ||
| return VerifyAPI.trackVerified(params); | ||
| } finally { | ||
| ConfigAPI.getConfig(params); // call with updated permissions |
There was a problem hiding this comment.
It doesn't seem like trackVerified is making any calls that would modify permissions
There was a problem hiding this comment.
Agreed, will simplify
kochis
reviewed
Jul 28, 2023
src/http.ts
Outdated
| }: { | ||
| method: HttpMethod; | ||
| path: string; | ||
| data?: any; | ||
| host?: string | undefined; |
There was a problem hiding this comment.
I think this can just be host?: string;, then you don't need the default argument above.
kochis
reviewed
Jul 31, 2023
src/http.ts
Outdated
| @@ -129,7 +132,11 @@ class Http { | |||
| } | |||
|
|
|||
| xhr.onerror = function() { | |||
| reject(new RadarServerError()); | |||
| if (host && host.includes('localhost')) { | |||
There was a problem hiding this comment.
We should include the port here, it's possible that localhost can be a valid host (ie. developing against dashboard locally)
There was a problem hiding this comment.
Good call, done
kochis
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
trackVerified(), which callsPOST /trackon desktop agent running onlocalhost:52516. Need to add error handling (e.g., case where desktop agent not installed or not running)