Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift when Radar.initialize is called in example app #257

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Shift when Radar.initialize is called in example app #257

wants to merge 4 commits into from

Conversation

KennyHuRadar
Copy link
Contributor

Radar.initialize is moved from being called inside useEffect to outside of App to prevent Map from trying to load before Radar.initialize is called

lmeier
lmeier approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@lmeier lmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

cc @nickpatrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmeier lmeier lmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KennyHuRadar @lmeier