Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the search form #264

Closed
iliion opened this issue Feb 1, 2023 · 6 comments
Closed

Bug in the search form #264

iliion opened this issue Feb 1, 2023 · 6 comments
Assignees
Milestone

Comments

@iliion
Copy link

iliion commented Feb 1, 2023

This is probably a Bug related to this feature and the strange behaviour is caused after this commit.


Explanation

In essence the above feature #253 will work only if the landing page (aka. the root catalog) contains the following link:

{
      "rel": "data",
      "type": "application/json",
      "href": <base_url_here> + "/collections",
      "method": "GET"
}

In case this link is not present then it is not possible to insert a collection manualy into the search form. Basically I insert a collection in the Collections text area and I press enter and then it appears in the Item IDs area (see screenshot).

image

I think the aforementioned feature is very useful and I was wondering if its possible to decouple its functionality from the fact that we need to keep a "data" link in the root catalog.


Note: Related issue

@m-mohr
Copy link
Collaborator

m-mohr commented Feb 1, 2023

Sure, that's a bug, I'll fix that. Thanks for reporting.

@m-mohr m-mohr added the bug label Feb 1, 2023
@m-mohr m-mohr self-assigned this Feb 1, 2023
@m-mohr m-mohr added this to the 3.0.0-rc.1 milestone Feb 1, 2023
@m-mohr
Copy link
Collaborator

m-mohr commented Feb 1, 2023

Please try again :-)

@iliion
Copy link
Author

iliion commented Feb 1, 2023

It is resolved. Thanks a lot @m-mohr

@iliion iliion closed this as completed Feb 1, 2023
@iliion
Copy link
Author

iliion commented Feb 2, 2023

Hi @m-mohr .It is true that now a user can insert a collection but the collections argument in the query string remains empty. I hadnt noticed it last night .

ex.: http://<host>/search?limit=12&collections=

Debug screenshot:
image

@m-mohr
Copy link
Collaborator

m-mohr commented Feb 2, 2023

I didn't had an API at hand yesterday that didn't had collections so this was somewhat a "blind" bug fix, but found one now so was able to actually check what's going on and it's fixed now as far as I can tell (at least it works for EarthSearch).

@m-mohr m-mohr closed this as completed Feb 2, 2023
@iliion
Copy link
Author

iliion commented Feb 2, 2023

It works fine :). I can confirm that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants