Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move heartbeat into its own thread (task manager) #327

Closed
andre-merzky opened this issue Mar 15, 2019 · 5 comments
Closed

move heartbeat into its own thread (task manager) #327

andre-merzky opened this issue Mar 15, 2019 · 5 comments

Comments

@andre-merzky
Copy link
Member

andre-merzky commented Mar 15, 2019

[cleaned out template]

@vivek-bala
Copy link
Contributor

Haha you didn't clear the issue template 😛

@andre-merzky
Copy link
Member Author

Nope I didn't - was supposed to be a quick placeholder :-P But let me expand on this now.

We discussed why the task manager is split in two threads: to avoid that actual work blocks the heartbeat progression which would lead to timeouts. The second thread takes over the actual work, the heartbeat works.

A simple approach with the same result is to move the heartbeat into its own thread - then the work stays localized in the main thread, and no communication and synchronization is needed between the threads (apart from some alive signal), simplifying the main loop of the process significantly.

@mturilli
Copy link
Contributor

mturilli commented Apr 9, 2019

Depends on when heartbeat will be available in RU v2

@lee212 lee212 added this to the Jan 2021 Release milestone Jul 7, 2020
@iparask
Copy link
Contributor

iparask commented Jan 5, 2021

I think this is already done. @andre-merzky can you verify? See here.

@andre-merzky
Copy link
Member Author

Yes, agree, this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants