Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_ special character is not allowed in names of Pipeline, Stage, and Task; failing data sharing #392

Closed
lee212 opened this issue Nov 22, 2019 · 2 comments · Fixed by #529
Closed

Comments

@lee212
Copy link
Contributor

lee212 commented Nov 22, 2019

To exchange or share data between tasks, e.g. copy_input_data, PST names are referenced but the underscore _ is used for parsing. The errors, otherwise, is seen like, if names contain this character:

p = Pipeline()
p.name = 'simple_mdff'
...
EnTKError: Value for attribute placeholder of object task incorrect.
 Expected value ('$Pipeline_(pipeline_name)_Stage_(stage_name)_Task_(task_name) 
or $SHARED',),
but got ['$Pipeline', 'simple', 'mdff', 'Stage', 'Generating a simulated density map', 
'Task', 'Starting to load the target PDB'].

pipeline name simple_mdff was accidentally sliced by the delimiter _.

A possible solution would be:

  • encoding names by base64 as it contains three special characters only +, /, =
  • prohibit using _ in names

expected = '$Pipeline_(pipeline_name)_' \

@lee212 lee212 added this to the Jan 2021 Release milestone Jul 7, 2020
@iparask
Copy link
Contributor

iparask commented Dec 24, 2020

I suggest excluding any special character from the pipeline, stage, and task names, apart from ..

@mturilli
Copy link
Contributor

I would agree but then I think we should check for naming before execution and raise an error if a name uses illegal characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants