Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better testing coverage for serialization of AWS resource type schemas #10

Open
willdavsmith opened this issue Feb 1, 2023 · 1 comment
Labels

Comments

@willdavsmith
Copy link
Contributor

willdavsmith commented Feb 1, 2023

Summary

We have identified multiple gaps in the AWS Bicep type generator which cause the output Bicep representation to be incomplete or broken. The number of resources affected so far by this class of issues is indeterminate, and these types of issues can cause the affected resources to be broken (cause the Bicep VSCode extension to crash).

Examples

https://github.com/project-radius/radius/issues/4971
https://github.com/project-radius/radius/issues/4973

Solution

We should do some investigation to determine what key types (e.g. oneOf) can exist in the AWS resource type schemas that are causing the generator to not serialize the Bicep types properly. We should also write regression tests for each of these that we find.

Definition of Done

This is up for debate. We could have tests for all of the major resources, and additional regression tests for any issues found during the investigation.

@asilverman
Copy link
Contributor

I think that the definition of done is to come up with a test plan and create tasks to implement automated tests similar to the jest tests that were created in the resolution of #9.

Coming up with a test plan requires researching the subject matter and coming up with the requirements for the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants