Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support symbols #9

Closed
radlinskii opened this issue Sep 29, 2023 · 5 comments
Closed

support symbols #9

radlinskii opened this issue Sep 29, 2023 · 5 comments
Assignees

Comments

@radlinskii
Copy link
Owner

radlinskii commented Sep 29, 2023

Support symbols inside the expected input.
Could be set as different levels (basic interpunction, programming), or even support user providing a list of symbols that could be used.

This feature should work similar to adding numbers inside the expected input. Please have a look inside the source code to see how it happens that if you pass numbers=true you can get numbers as part of your test's expected input.

User should be able to set it as an argument when running the program or put it inside her/his config file.

@kritikash18
Copy link
Contributor

Hey, can I work on this? Came back here 👋

@radlinskii
Copy link
Owner Author

Sure 👍

@kritikash18
Copy link
Contributor

Raised PR #40

@phoffmeister
Copy link
Contributor

Also just created a PR for this #43 . This was an unfortunate timing. There was no update for a week so I looked into this. Then I saw the PR mentioned above. Still wanted to share what I did so far. Feel free to just discard my PR @radlinskii

@radlinskii
Copy link
Owner Author

after reviewing both PRs I merged #43 because:

  • it was better documented,
  • handled tests,
  • didn't introduce new dependency

Sorry @kritikash18 and thanks for your contribution, of course added hacktoberfest-accepted label to your PR too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants