Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrappers: Fix user argument handling #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

wrappers: Fix user argument handling #10

wants to merge 4 commits into from

Conversation

raffenet
Copy link
Owner

Pull Request Description

Expected Impact

Author Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Remove xfail from the test suite when fixing a test
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers
  • Passes warning tests
  • Passes all tests
  • Add comments such that someone without knowledge of the code could understand
  • Add Devel Docs in the doc/ directory for any new code design

@raffenet
wrappers: Remove argument quoting from sh scripts
7f73b15 
Do not try to quote additional user arguments. Just repeat them
verbatim. See pmodels#4171.
@raffenet
wrappers: Remove erroneous array expansion
e755c01 
In the /bin/sh wrappers, allargs variable is a string. Remove array
expansion that slipped in. Closes pmodels#1471.
@raffenet
wrappers: Make allargs handling consistent
421bc9b 
Remove redundant quotes. Always use brackets.
@raffenet
[DNM]: Hack to force /bin/sh wrapper script usage
8c1dc8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@raffenet