Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention alternative of HashRouter #64

Open
deantork-sc opened this issue Jan 3, 2023 · 5 comments
Open

Mention alternative of HashRouter #64

deantork-sc opened this issue Jan 3, 2023 · 5 comments

Comments

@deantork-sc
Copy link

I was having problems with my SPA in Github Pages, and found a few solutions to the problem. This project fixes the problem in a roundabout way, and a slightly more direct solution is using HashRouter instead of BrowserRouter. I don't know if this fixes all instances of this problem, but it worked for me.

I think the readme should mention this alternative for folks who want a more lightweight solution.

@gatinhap
Copy link

@deantork-sc, thanks, for me it worked as well!

@lucharo
Copy link

lucharo commented Apr 16, 2023

Do you have examples of how to achieve this? @deantork-sc @gatinhap

@gatinhap
Copy link

@lucharo - you can have a look into my repo where I use it - https://github.com/gatinhap/magdak and the specific file - https://github.com/gatinhap/magdak/blob/main/src/main.jsx.
Instead of wrapping my <App/> in BrowserRouter, I wrapped it in HashRouter and that's all :)

@lucharo
Copy link

lucharo commented Apr 28, 2023

Thanks for the reply I made it work in the end. I was confused at the fact I couldn't serve my builds folder with serve -s build when my package.json included my GitHub pages url as the homepage field but then I realised despite that the site does build correctly in gh pages itself 🎉 https://luischaves.xyz/recipe-portfolio https://github.com/lucharo/recipe-portfolio

@stxgao
Copy link

stxgao commented Oct 29, 2023

Agree that this should be mentioned as an alternative.

However, I wanted to add that I came here from my HashRouter implementation, since I wanted more shareable links (without the /#/ prefixing all my routes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants