Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll-to does not work with a custom scrollable which is at the top of the document #43

Open
chbonser opened this issue Aug 20, 2018 · 0 comments

Comments

@chbonser
Copy link

The fundamental problem is the addon recommends setting the scrollable property on the service. This leaves the service to perform an inaccurate check to see if the user overwrote the scrollable propery (https://github.com/c4eo/ember-scroll-to/blob/master/addon/services/scroller.js#L39). Clearly this check doesn't work if top is 0.

I'll submit a PR shortly which adds an acceptance test and fixes the bug. I won't change the recommendation to set scrollable as that would be a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant