You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fundamental problem is the addon recommends setting the scrollable property on the service. This leaves the service to perform an inaccurate check to see if the user overwrote the scrollable propery (https://github.com/c4eo/ember-scroll-to/blob/master/addon/services/scroller.js#L39). Clearly this check doesn't work if top is 0.
I'll submit a PR shortly which adds an acceptance test and fixes the bug. I won't change the recommendation to set scrollable as that would be a breaking change.
The text was updated successfully, but these errors were encountered:
The fundamental problem is the addon recommends setting the
scrollable
property on the service. This leaves the service to perform an inaccurate check to see if the user overwrote thescrollable
propery (https://github.com/c4eo/ember-scroll-to/blob/master/addon/services/scroller.js#L39). Clearly this check doesn't work if top is 0.I'll submit a PR shortly which adds an acceptance test and fixes the bug. I won't change the recommendation to set
scrollable
as that would be a breaking change.The text was updated successfully, but these errors were encountered: