Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable loading .env file when running foreman for development #388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Flixt
Copy link

@Flixt Flixt commented Aug 6, 2024

Same as in rails/cssbundling-rails#155 and rails/jsbundling-rails@0ff85a2

We should just not load the .env when running foreman locally for bundling etc.

@flavorjones flavorjones requested a review from dhh August 7, 2024 13:20
@dhh
Copy link
Member

dhh commented Aug 8, 2024

We're actually fixing this in Kamal 2, which will be out before Rails 8, so that it uses .kamal/secrets instead of .env. So I'm not sure this is actually necessary, and would prevent the use of .env for legitimately passing on envs to foreman.

@Flixt
Copy link
Author

Flixt commented Aug 8, 2024

Okay. But I think that tailwindcss-rails, cssbundling-rails, jsbunding-rails and dartsass-rails should generate a bin/dev file with the same behavior. Currently only cssbundling-rails and jsbundling-rails generate bin/dev excluding the env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants