Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

991 get vault balances for an order in cli #996

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

991 get vault balances for an order in cli #996

wants to merge 34 commits into from
+138 −0

Conversation

ninokeldishvili
Copy link

@ninokeldishvili ninokeldishvili commented Nov 13, 2024 •
edited
Loading

Motivation

get vault balances for an order in cli

Solution

Add the logic to get vault balances for orders in cli

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@ninokeldishvili ninokeldishvili linked an issue Nov 13, 2024 that may be closed by this pull request
get vault balances for an order in cli #991
Open
@ninokeldishvili ninokeldishvili self-assigned this Nov 13, 2024
thedavidmeister
thedavidmeister requested changes Nov 21, 2024
View reviewed changes
crates/cli/src/balance.rs Outdated Show resolved Hide resolved
crates/cli/src/balance.rs Outdated Show resolved Hide resolved
crates/cli/src/balance.rs Outdated Show resolved Hide resolved
crates/cli/src/balance.rs Outdated Show resolved Hide resolved
thedavidmeister
thedavidmeister requested changes Nov 21, 2024
View reviewed changes
crates/cli/src/balance.rs Outdated Show resolved Hide resolved
@ninokeldishvili ninokeldishvili mentioned this pull request Nov 28, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedavidmeister thedavidmeister thedavidmeister approved these changes

@hardyjosh hardyjosh Awaiting requested review from hardyjosh

Assignees

@ninokeldishvili ninokeldishvili

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get vault balances for an order in cli
2 participants
@ninokeldishvili @thedavidmeister