-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dns.default == dns.time? #36
Comments
Basically so the compare dashboard can work without having to have a Kind of like a temporary hack to make "default" unit/metric alias more -r Raj Dutt co-founder/ceo, raintank On Thu, Jan 14, 2016 at 12:29 AM, Dieter Plaetinck <[email protected]
|
ah i see. i think with some better naming structure we can make templating easier and remove the need to store the same data twice.
this way time_total can replace both time and default for dns, and make it easy to compare across protocols |
how would you compare this with Ping? Ping doesnt have a "time_total" measurement. instead the default is "mean" or "time_mean" if you want to standardize format. |
for ping i just wouldn't make mean part of the metric name. i see how "total" could be misleading. just calling it "time" should do then. and for protocols that want to split it up can do so in a subcategory as long as it has a different name, like |
but if you had
how would you know that time actually meant "mean"? |
by convention i suppose. or documentation. it seems much more of a stretch to know that default means time (and total time and mean time depending on protocol). btw isn't our avg also the same as mean? i just tried a few and they look exactly the same. what's the difference? |
A user browsing the metric tree doesnt need to know what "default" is as it is simply an 'alias' to another of the metrics (we obviously dont have a way to create a real alias, so just duplicate the metric).
Good point that is a pretty big oversight as what we are storing as mean is actually the 'median' |
what is the dns.default metric and why does it look identical to dns.time?
( and also i noticed it doesn't show up for hosts that don't resolve, which may be ok)
The text was updated successfully, but these errors were encountered: