singular values

[tyronerees]

The svd is computed, but is never used except to print to the screen. Is this still needed? If not, remove.

Return status (svdstatus) from get_svd_j is not checked.
There is no logic to handle svdstatus/=0.

Is it possible to remove altogether this routine and associated code?

Remove w%smallest_sv %largest_sv as well as
inform%smallest_sv %largest_sv

[tyronerees]

I've looked at the code, and I'm pretty sure this can be removed -- I've done this locally without any adverse affects on the test deck. I think I'll keep this local for now, though (until PR #18 is merged into master) as it will only take five minutes to do, but will probably create a mess of merge conflicts that will be horrible to resolve.

[talassio]

Sounds good! we can merge it after PR #18. cheers,

…

On Tue, 2 Apr 2019 at 16:27, Tyrone Rees ***@***.***> wrote: I've looked at the code, and I'm pretty sure this can be removed -- I've done this locally without any adverse affects on the test deck. I think I'll keep this local for now, though (until PR #18 <#18> is merged into master) as it will only take five minutes to do, but will probably create a mess of merge conflicts that will be horrible to resolve. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHKFk5MCP4d05CzD7oLTbVLW7oh_cqY6ks5vc3b5gaJpZM4bZHsC> .