Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDA does not seem work? #2

Open
aentity opened this issue Jan 21, 2022 · 1 comment
Open

DDA does not seem work? #2

aentity opened this issue Jan 21, 2022 · 1 comment

Comments

@aentity
Copy link

aentity commented Jan 21, 2022

@ramakarl in other issue you ask for vertices, for these:

    Vector3DF(
        0.0,
        -20.81406,
        8.171592
    ),
    Vector3DF(
        0.0,
        -14.862897,
        -13.38261
    ),
    Vector3DF(
        20.0,
        0.0,
        0.0
    )

it seems clear that d1 will be invalid, as we will divide by 0 here: https://github.com/ramakarl/voxelizer/blob/master/math_voxelizer/main_voxelizer.cpp#L237

have you tested this by rotating the triangle about the planes using quaternions on every axis?

@Dimension4
Copy link

Just ran into this issue, too. Triangle coordinates are

[0]: {51.7321903761628, 6.135542782570875, -55.063580406614726}
[1]: {51.62424037616284, 6.1941068919916935, -55.09661639885565}
[2]: {51.6242403761628, 6.135542782570935, -55.06358040661471}

and space bounds are

m_vmin = {-33.56288012881984, -4.107472231053617, -193.37669756689073}
m_vmax = {149.19836501802786, 19.888678754569305, 24.251550699393917}
m_vres = {367, 49, 437}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants