Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Forward Slashes from User Retention Tests #1578

Open
caliskanugur opened this issue Oct 3, 2024 · 1 comment
Open

Remove Forward Slashes from User Retention Tests #1578

caliskanugur opened this issue Oct 3, 2024 · 1 comment
Assignees
Milestone

Comments

@caliskanugur
Copy link
Member

Currently, slack reporter for recurring run fails with:

05:15:58.491 [31mERRO[0m[0114] error reporting: error with slack message post: 400 Bad Request 400: ****

The potential problem is: that it uses string manipulation to check the forward slashes. It sends the wrong parsed string to the slack API.

Example names (there are more, make sure to check names) that need updates: https://github.com/rancher/rancher/blob/release/v2.9/tests/v2/validation/auth/userretention/userretention_settings_test.go#L191-L193

Extra information about forward slashes in the test names: https://github.com/rancher/rancher/tree/main/tests#how-to-write-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants