hide rke2-uninstall.sh to avoid accidental deletion of RKE2

[harridu]

Its easy to run rke2-uninstall.sh instead of rke2-killall.sh by accident or out of confusion, esp. if command line completion is enabled. This is fatal. I would suggest to better hide the uninstall scripts.

[brandond]

I don't believe this is something we're likely to do. There are a lot of mistakes an inattentive cli user may make; every user who's ever run rm -rf / on accident can sympathize. The solution is to type carefully, rather than expecting your tools to remove every potentially harmful command from being suggested by shell completion.

[harridu]

Of course its a mistake to run the harmful command, but rke2-uninstall.sh sounds as destructive as rke2-killall.sh. Moving it to somewhere else (outside of the usual $PATH) would be a defensive measure not hurting anybody.

It is even lacking a confirmation dialog, nor does it catch something like "rke2-uninstall.sh --help". Not best practice.

[thrashwerk]

While I don't think it's a huge problem because you should be able to quickly get that node back in the cluster, the script could be improved. It could display some info when ran with --help, ask for confirmation when ran with no flags and maybe a -y flag that immediately starts uninstalling if you'd need to run it on multiple servers at once.

[harridu]

I highly appreciate your work on RKE2.

[caroline-suse-rancher]

Closing this as it's not currently in our plans to modify