Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to avoid problems with chart images #4485

Closed
manuelbuil opened this issue Jul 19, 2023 · 2 comments
Closed

Add test to avoid problems with chart images #4485

manuelbuil opened this issue Jul 19, 2023 · 2 comments
Assignees

Comments

@manuelbuil
Copy link
Contributor

Is your feature request related to a problem? Please describe.

From time to time we, humans, introduce image-related bugs into the rke2 code because:

I think it should be easy to verify with a simple test that a PR is not adding any bug related to these problems. Probably limit its run to PRs that update Dockerfile, which is the file changed to update charts.

Describe the solution you'd like

Test that would block the PR because it is adding a bug related to chart images

Describe alternatives you've considered

Additional context

@thomasferrandiz
Copy link
Contributor

/backport v1.26.11+rke2r1

@thomasferrandiz thomasferrandiz added this to the v1.28.4+rke2r1 milestone Nov 13, 2023
@thomasferrandiz
Copy link
Contributor

/backport v1.27.8+rke2r1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants