Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor windows CNI code to simplify the support of new CNI plugins #5275

Closed
manuelbuil opened this issue Jan 15, 2024 · 1 comment
Closed
Assignees

Comments

@manuelbuil
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Related to #5215, we need to abstract how pebinary talks to the CNI plugin. Right now, as Calico is the only CNI plugin, there is a lot of Calico specific stuff

Describe the solution you'd like

  • An interface that each CNI plugin can honor
  • A common config struct
    Both objects could be used by pebinary without having to know details on the CNI plugin

Describe alternatives you've considered

Additional context

@rancher-max
Copy link
Contributor

A few issues around this are similar. The code went through a few iterations and required some changes tracked by this, but I'm going to close this one in favor of the Calico and Flannel Windows issues directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants