Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell completion support to RKE2 #5488

Closed
caroline-suse-rancher opened this issue Feb 20, 2024 · 4 comments
Closed

Add shell completion support to RKE2 #5488

caroline-suse-rancher opened this issue Feb 20, 2024 · 4 comments
Assignees
Labels
kind/enhancement An improvement to existing functionality priority/medium

Comments

@caroline-suse-rancher
Copy link
Contributor

caroline-suse-rancher commented Feb 20, 2024

Is your feature request related to a problem? Please describe.

Currently, RKE2 does not support shell completion.

Describe the solution you'd like

Enable shell completion on RKE2. Shell completion installation should also set up the correct environment variables for kubectl and crictl to work properly using the default RKE2 paths.

Additional context

Ideally, this may help address #5250 (Jira Ref: SURE-7427)

@megabreit
Copy link

In the original issue #5250 also ctr was mentioned, but the completion patch only deals with crictl. Is there any reason for that? Or was it just forgotten?

@brandond
Copy link
Member

cc @vitorsavian - can we open another issue to track adding ctr?

@fmoral2
Copy link
Contributor

fmoral2 commented Aug 22, 2024

@fmoral2 fmoral2 closed this as completed Aug 22, 2024
@megabreit
Copy link

megabreit commented Oct 4, 2024

Why didn't you just add a file to /etc/bash_completion.d like others do? This way things would work "automagically" and there would be no need to manually add it.

Why is rke2 completion bash not installing any completion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement An improvement to existing functionality priority/medium
Projects
None yet
Development

No branches or pull requests

5 participants