Add e2e validation test for kine #7168
Conversation
| var agentCount = flag.Int("agentCount", 1, "number of agent nodes") | ||
| var ci = flag.Bool("ci", false, "running on CI") | ||
|
|
||
| // Environment Variables Info: |
There was a problem hiding this comment.
Add a line here about E2E_EXTERNAL_DB as that is the primary variable that will change with this test.
tests/e2e/kine/Vagrantfile
Outdated
| @@ -0,0 +1,157 @@ | |||
| ENV['VAGRANT_NO_PARALLEL'] = ENV['E2E_STANDUP_PARALLEL'] ? nil : 'no' | |||
| NODE_ROLES = (ENV['E2E_NODE_ROLES'] || | |||
| ["server-0"]) | |||
There was a problem hiding this comment.
Let's change the default to 3 server if we want to run with three servers
There was a problem hiding this comment.
Why would 3 servers need to be the default, its all the same for External DB
vitorsavian
force-pushed
the
e2e-kine
branch
3 times, most recently
from
740314e to
f7cb0c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7168 +/- ##
=========================================
- Coverage 16.62% 8.87% -7.76%
=========================================
Files 32 33 +1
Lines 3423 3438 +15
=========================================
- Hits 569 305 -264
- Misses 2812 3110 +298
+ Partials 42 23 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vitor Savian <[email protected]>
Signed-off-by: Derek Nola <[email protected]>
Proposed Changes
Types of Changes
Verification
Testing
Linked Issues
User-Facing Change
Further Comments
validateCluster? My main thought was that the validateCluster test was made for rke2 without experimental features, so kine needs its own place.